update to stop closures from lazy functions and linq#11934
Merged
rainersigwald merged 2 commits intodotnet:mainfrom Jun 6, 2025
Merged
update to stop closures from lazy functions and linq#11934rainersigwald merged 2 commits intodotnet:mainfrom
rainersigwald merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR eliminates closures and LINQ allocations by switching from a lazy Func<string, bool> to an eagerly initialized delegate and by replacing .Where(...) calls with manual loops.
- Changed
excludeTesterfromLazy<Func<string,bool>>toFunc<string,bool>and moved its initialization into the processing loop. - Replaced LINQ-based filtering (
AddRange(...Where(...))) with explicitforeachand conditionalAdd. - Updated
ValueFragmenthandling to call the tester directly.
Comments suppressed due to low confidence (1)
src/Build/Evaluation/LazyItemEvaluator.IncludeOperation.cs:55
- The variable
excludePatternsForGlobsis declared but never used; consider removing it to reduce dead code.
ISet<string>? excludePatternsForGlobs = null;
rainersigwald
approved these changes
Jun 2, 2025
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
Before you fix the bug, can you please try to add a unit test that fails instead
SimaTian
approved these changes
Jun 5, 2025
Contributor
Author
@rainersigwald I'm not sure I follow on what scenario to fail on the unit test would be. Can you explain a bit more? |
Member
|
Oh sorry, that comment was left over from your first revision that failed on the second-phase build; you've fixed it already. Ignore it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : Allocation issue.
Context
Looking at a trace of allocations. It was shown that some of the allocations were coming from closures. This pr addresses the closures found.
Changes Made
Testing
Used ILSpy to verify that the closures disappeared. (DisplayClass represents a closure)
Before
Afterwards
Notes